ext4 read-only for now #218
Conversation
|
Great job! Is there any contribution that I might do to speed things up? E.g. adding tests, docs? |
|
Yeah, thank you @shanduur . Tests are next. I would start with unit tests on small functions, as I am positive there are errors of calculation in various places. FWIW, I do have the beginnings of write capability in a separate local branch, but we should get read working correctly first. |
|
If it is just small things, comment on the PR. If it is wholesale additions or changes, just open a PR to the |
deitch
force-pushed
the
ext4
branch
6 times, most recently
from
aa5379d to
833cd48
Compare
|
lint is clean, that is something. Now it needs tests, both unit and actual integration, to get it to actually work. |
deitch
force-pushed
the
ext4
branch
17 times, most recently
from
210533c to
a4ce2ed
Compare
deitch
force-pushed
the
ext4
branch
12 times, most recently
from
b98da94 to
39d5a56
Compare
Signed-off-by: Avi Deitcher <[email protected]>
|
As far as I am concerned, ext4 read-only is ready. I am going to merge in as soon as CI is clean. ext4-write is for another day, although I have part of it, and may push out a branch. |
This is a first attempt at getting ext4 live. To get past some challenging parts, I am focusing on ext4 read-only first.
The current package
filesystem/ext4/does pass vet, and can compile. linting will require a lot more cleanup.There are almost no tests on it, and it has not been tested manually.
Steps: